Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add figures for box lines #56

Closed
ehmicky opened this issue Mar 24, 2021 · 6 comments · Fixed by #70
Closed

Add figures for box lines #56

ehmicky opened this issue Mar 24, 2021 · 6 comments · Fixed by #70

Comments

@ehmicky
Copy link
Collaborator

ehmicky commented Mar 24, 2021

What are your thoughts on adding figures for box lines?

They display well on all environments. The following screenshots shows them both as individual characters, and displayed on several rows/columns.

Ubuntu 20.10, Gnome terminal:

unix_2

Windows 10, cmd.exe (CP850):

windows_2

I checked on macOS default terminal, and it looks good too 👍

I believe all of the above are useful, but offering a subset is also an option. The high number of characters is mostly due to different variants of dashes and boldness.

At the moment, the only related figure in this library is line (U-2500) (not included above).

@sindresorhus
Copy link
Owner

👍 To the person that ends up submitting a PR for this, good luck naming all of these.

@ehmicky
Copy link
Collaborator Author

ehmicky commented Mar 24, 2021

I think we can use system of prefixes and suffixes (although I agree the names will most likely be verbose).

@ehmicky
Copy link
Collaborator Author

ehmicky commented Mar 24, 2021

Proposal for naming:

  • line, e.g. ━
  • lineVertical, e.g. ┃
  • lineDownRight, lineDownLeft, lineUpRight or lineUpLeft, e.g. ┏ ┓ ┗ ┛
  • lineUpDownRight, lineUpDownLeft, lineDownLeftRight or lineUpLeftRight, e.g. ┣ ┫ ┳ ┻
  • lineUpDownLeftRight, e.g. ╋
  • lineCross for ╳
  • lineBackslash for ╲
  • lineSlash for ╱

This can be followed by "variants":

  • nothing/empty, e.g. │
  • Bold, e.g. ┃
  • Double, e.g. ║
  • Dashed0, Dashed1, ..., Dashed15 for all dashed variants, e.g. ┇

When a symbol combines several variants, they are appended to each part of it. For example, lineUpBoldDownLeftBoldRight for ╃

I would also suggest leaving out (U-203e) as it is not centered and not really meant as a box line.

What do you think?

@sindresorhus
Copy link
Owner

That sounds good to me.

@sindresorhus
Copy link
Owner

I would also suggest leaving out ‾ (U-203e) as it is not centered and not really meant as a box line.

👍

@ehmicky
Copy link
Collaborator Author

ehmicky commented Mar 29, 2021

Done at #70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants