Correct typing for things that handle exceptions

They really handle BaseException, so document as such!
simplistix · Jun 5, 2024 · 4ee63aa · 4ee63aa
1 parent 9d63918
commit 4ee63aa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/testfixtures/comparison.py b/testfixtures/comparison.py
@@ -139,7 +139,7 @@ def compare_object(
 
 
 def compare_exception(
-        x: Exception, y: Exception, context: 'CompareContext'
+        x: BaseException, y: BaseException, context: 'CompareContext'
 ) -> Optional[str]:
     """
     Compare the two supplied exceptions based on their message, type and

diff --git a/testfixtures/shouldraise.py b/testfixtures/shouldraise.py
@@ -4,7 +4,7 @@
 
 from testfixtures import diff, compare
 
-ExceptionOrType = Union[Exception, Type[Exception]]
+ExceptionOrType = Union[BaseException, Type[BaseException]]
 
 
 param_docs = """