Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert commit 17106d8f #103

Closed
GuySartorelli opened this issue Sep 11, 2023 · 3 comments
Closed

Revert commit 17106d8f #103

GuySartorelli opened this issue Sep 11, 2023 · 3 comments

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Sep 11, 2023

That commit makes a bunch of changes that skipped the peer review process, which definitely need to be talked about before they're made:

  • Change code/ to src/
  • add allow-plugins (which shouldn't be added to modules)
  • change an intentional exception to a console error, which is arguably a breaking change but at least a change to the intent of the module.

When upgrading the module to CMS 5 compatability we made an intentional decision not to change or remove this exception, since a missing spam protection module is a clear example of missing dependencies that a developer needs to be aware of early on. If there's no spam protection module utilising this one, then this module should not be installed on that project.

PR

@GuySartorelli
Copy link
Member Author

FYI @wilr - after it has been reverted, feel free to submit a pull request so that the correct peer review process can take place.

@GuySartorelli
Copy link
Member Author

GuySartorelli commented Sep 11, 2023

The linked PR was merged

@wilr
Copy link
Member

wilr commented Sep 11, 2023

@GuySartorelli New PR for you to add any comments too at #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants