-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert commit 17106d8f #103
Comments
FYI @wilr - after it has been reverted, feel free to submit a pull request so that the correct peer review process can take place. |
The linked PR was merged |
@GuySartorelli New PR for you to add any comments too at #105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
That commit makes a bunch of changes that skipped the peer review process, which definitely need to be talked about before they're made:
code/
tosrc/
When upgrading the module to CMS 5 compatability we made an intentional decision not to change or remove this exception, since a missing spam protection module is a clear example of missing dependencies that a developer needs to be aware of early on. If there's no spam protection module utilising this one, then this module should not be installed on that project.
PR
The text was updated successfully, but these errors were encountered: