Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from sheadawson/silverstripe-linkable #230

Closed
maxime-rainville opened this issue Feb 18, 2024 · 4 comments
Closed

Migration from sheadawson/silverstripe-linkable #230

maxime-rainville opened this issue Feb 18, 2024 · 4 comments

Comments

@maxime-rainville
Copy link

maxime-rainville commented Feb 18, 2024

As a developer maintaining a project using sheadawson/silverstripe-linkable, I have a a clear path and clear guidance on how to migrate to v4.

Acceptance criteria

  • An automated task exists to converts sheadawson/silverstripe-linkable data to v4 linkfield format.
    • The task accounts for versioning and all pre-existing links are assumed to be published.
    • Task can be extended to accommodate unusual usage of LinkField.
  • Clear guidance on how to migrate to LinkField v4 is provided
  • Guidance covers the scenario where a project is upgraded all the way from CMS 4.
  • Guidance explicitly mentions that it is the developers responsibility to implement logic to cover custom link types.
  • Guidance covers how to completely remove the linkable module.
  • Guidance mentions feature gap between two linkfield implementations, but leave the developer to resolve these issue themselves.
  • Migration task is marked as @deprecated.
  • The task is disabled by default.

PR

@emteknetnz emteknetnz changed the title Migration form sheadawson/silverstripe-linkable Migration from sheadawson/silverstripe-linkable Feb 18, 2024
@sabina-talipova sabina-talipova self-assigned this Mar 4, 2024
@GuySartorelli
Copy link
Member

GuySartorelli commented Mar 17, 2024

FYI @sabina-talipova We discussed in standup today - these migration tasks have missed the cut-off for making it into the 4.0.0 stable release, so we'll need to target the 4 branch for them to be included in a future minor release.

@sabina-talipova
Copy link
Contributor

For further implementation, it is required that this PR be merged into the main branch 4 first. New trait is required.

@GuySartorelli
Copy link
Member

@sabina-talipova the gorriecoe migration PRs have all been merged now

@GuySartorelli
Copy link
Member

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants