-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT
commit is triggering auto-tagging, but shouldn't
#111
Comments
PR merged, assigned to Steve to check if it worked (if there's a way to do so) |
I don't know of a way to test this short of adding random MNT commits with leading bullet points, which I don't want to do. I'll just close this and we can revisit if it turns out there's an issue in the future |
Reopening - it's still happening. See https://github.com/tractorcow-farm/silverstripe-fluent/releases/tag/7.1.3 |
Issue on the linked tag was that the commit message was multiline:
Commits are parsed line by line looking for non MNT/Doc/Merge/[space] commits. If it finds a single line like this it will perform a release. While we could only look at the first line, we'll now be NOT releases if we have a squashed PR will multiple commits where the message looks something like this
I don't really see a way around this. Either we release too much as we do now, or we risk not releasing things when they should have been released. The downside of releasing maintainence only commits is very low, and I think it has much less downside then not releasing things that should be released I'll close this |
A release was made for
silverstripe/admin
that only included aMNT
commit. See https://github.com/silverstripe/silverstripe-admin/releases/tag/2.1.20MNT
commits should not be triggering releases.Acceptance criteria
PR
The text was updated successfully, but these errors were encountered: