Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.3 support in CMS 5.2.0 #88

Closed
4 tasks done
GuySartorelli opened this issue Aug 10, 2023 · 6 comments
Closed
4 tasks done

PHP 8.3 support in CMS 5.2.0 #88

GuySartorelli opened this issue Aug 10, 2023 · 6 comments
Assignees
@GuySartorelli
Labels
affects/v5 type/enhancement
Milestone
Silverstripe CMS 5.2

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Aug 10, 2023 •
edited by sabina-talipova
Loading

PHP 8.3 releases in November 2023.
As per our major release policy we aim to support PHP 8.3 in early 2024 - which realistically means in Silverstripe CMS 5.2.0

We need to make sure we resolve any compatibility issues by then, make sure we update docs to indicate PHP 8.3 support, and add PHP 8.3 to our CMS 5 CI runs for 5.2.0 and up.

Acceptance criteria

  • CI for CMS 5x run PHP8.3 builds
  • CI for CMS 4 does not run PHP 8.3 builds
  • Doc is updated
  • Create a follow up card to review build status of unsupported module for PHP 8.3

Related

  • official release notice
  • What's new in PHP 8.3
  • CMS 5.1 builds may very well be green on PHP 8.3 ... or very close to. If it's easier to patch CMS 5.1 to be green on PHP 8.3,
    feel free to do so.
  • Module that lost official support with CMS 5 should get the new PHP 8.3 build automatically.

PRs

Follow up card
@GuySartorelli GuySartorelli added this to the Silverstripe CMS 5.2 milestone Aug 27, 2023
@sabina-talipova sabina-talipova mentioned this issue Nov 21, 2023
Merged
@sabina-talipova
Copy link
Contributor

Passed CI with new matrix: https://github.com/sabina-talipova/silverstripe-installer/actions/runs/6961894106

@sabina-talipova
Copy link
Contributor

Final implementation requires that all third-party modules also support PHP 8.3.
Currently, blocked at least by "laminas/laminas-ldap" module, that has strict constraints "php": "~8.0.0 || ~8.1.0 || ~8.2.0".

@sabina-talipova sabina-talipova mentioned this issue Nov 22, 2023
Merged
@GuySartorelli
Copy link
Member Author

Given the ldap repo hasn't had any commits to its default branch in 10 months, it doesn't seem likely this will happen quickly on its own... I've opened an issue in their repo to hopefully get the ball moving: laminas/laminas-ldap#46

@GuySartorelli
Copy link
Member Author

LDAP now supports PHP 8.3 as of 2.18.0 - it's no longer a blocker.

@sabina-talipova
Copy link
Contributor

Passed CI with new matrix:
Sink: https://github.com/sabina-talipova/recipe-kitchen-sink/actions/runs/7177998490/job/19545421461
Installer: https://github.com/sabina-talipova/silverstripe-installer/actions/runs/7186208374/job/19571116193

@sabina-talipova sabina-talipova removed their assignment Dec 12, 2023
@GuySartorelli
Copy link
Member Author

PRs merged and CI tagged. We'll see if there are any failures in rhino as the builds run, and can fix them as the need arises.

@GuySartorelli GuySartorelli mentioned this issue Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
Silverstripe CMS 5.2
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova