You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was trying to connect to an oracle instance and my code panicked, after investigating the issue I found that go-ora will not validate the database is serving queries, only that the host + port name are returning OK. Since the listener could be working but the oracle instance be down, during connection process we will not find any issues and try to perform a query in getDBTimeZone() if we don't have timezone for the server.
The first PR fixes the panic that was happening because we're not checking the type of the response before trying to cast and also validates the data returned is the correct type.
Description
I was trying to connect to an oracle instance and my code panicked, after investigating the issue I found that go-ora will not validate the database is serving queries, only that the host + port name are returning OK. Since the listener could be working but the oracle instance be down, during connection process we will not find any issues and try to perform a query in
getDBTimeZone()if we don't have timezone for the server.The first PR fixes the panic that was happening because we're not checking the type of the response before trying to cast and also validates the data returned is the correct type.
Related PRs:
#633
#636
The text was updated successfully, but these errors were encountered: