Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No error is raised if pushGateway server returned a 400 or 500 #579

Closed
kdeberk opened this issue Jul 19, 2023 · 2 comments
Closed

No error is raised if pushGateway server returned a 400 or 500 #579

kdeberk opened this issue Jul 19, 2023 · 2 comments

Comments

@kdeberk
Copy link
Contributor

kdeberk commented Jul 19, 2023

Using the Pushgateway we noticed that the gravel gateway server (this one) can sometimes reject our POST, PUT or DELETE request and return a 400 (or sometimes even 500). If that happens, then the pushAdd, push, and delete calls do not throw an exception. This prevents us from noticing the issue.
@kdeberk
Copy link
Contributor Author

kdeberk commented Jul 19, 2023 •
edited
Loading

I've added a PR to raise an error if the gateway server returned a >= 400 status code.

@zbjornson
Copy link
Collaborator

Fixed in #578, thanks for the contrib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zbjornson @kdeberk