Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why was timestamp support removed? #376

Closed
jdziat opened this issue Jun 26, 2020 · 1 comment
Closed

Why was timestamp support removed? #376

jdziat opened this issue Jun 26, 2020 · 1 comment
Labels

Comments

@jdziat
Copy link

jdziat commented Jun 26, 2020

Hi Guys,
Love the library and i use it often. Just wondering why the timestamp value for metrics were removed(#333). Is this a best practice? I don't see it mentioned anywhere in https://prometheus.io/docs/instrumenting/exposition_formats/. If someone kept polling an endpoint and the time wasn't changing i would think that would indicate an error and something you should alert on. You can configure prometheus to ignore those timestamps if necessary in your environment as well.

example:

metric.set({}, 0, new Date())
@zbjornson
Copy link
Collaborator

There's an explanation in #177 from one of the Prometheus core maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants