-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance tests failing after latest protobuf-specs python release #178
Comments
I think our requirements.txt should pin versions (at least protobuf-specs) strictly:
|
oops that's a lie. We don't have dependabot! I still suggest following:
This might mean some trouble with sigstore-python testing specifically (if sigstore-python wants to pin a different version of protobufs) but I think that should be solved with separate environments rather than by allowing other clients to fail suddenly. EDIT: actually sigstore-python currently gets installed outside the virtual env on CI: not ideal but maybe mostly works in this context. |
So debugging a little further: this issue does not show up in our self tests because
We probably do want to start installing a sigstore-python in its own virtual env so different pinned deps are possible |
Let's do a release once the linked PRs are merged and look ok: I think the action is currently broken for everyone (except the selftest here and sigstore-python) |
Thanks y'all for the quick fix! |
Confirmed passing, thanks again! https://github.com/sigstore/cosign/actions/runs/12752366181 |
See https://github.com/sigstore/cosign/actions/runs/12738467371/job/35500829830 for an example.
cc @woodruffw
The text was updated successfully, but these errors were encountered: