Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --verify-digest flag, clients should parse the target #161

Closed
loosebazooka opened this issue Oct 2, 2024 · 0 comments · Fixed by #162
Closed

Remove --verify-digest flag, clients should parse the target #161

loosebazooka opened this issue Oct 2, 2024 · 0 comments · Fixed by #162
Labels
enhancement New feature or request

Comments

@loosebazooka
Copy link
Member

https://github.com/sigstore/sigstore-conformance/blob/main/docs/cli_protocol.md#bundle-flow-1 has --verify-digest flag to select how to handle the positional argument FILE_OR_DIGEST.

Clients should just consider anything that starts with sha256: as a digest and everything else as a file. We can remove the --verify-digest flag.
@loosebazooka loosebazooka added the enhancement New feature or request label Oct 2, 2024
@loosebazooka loosebazooka mentioned this issue Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove --verify-digest flag sigstore/sigstore-conformance
1 participant
@loosebazooka