Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First-class attachment support #618

Closed
dlorenc opened this issue Sep 3, 2021 · 5 comments
Closed

First-class attachment support #618

dlorenc opened this issue Sep 3, 2021 · 5 comments

Comments

@dlorenc
Copy link
Member

dlorenc commented Sep 3, 2021

With #615 in, we should firm up and support the other attachment types (SBOMs, signatures and attestations) across the CLI. We can upload, download, attach, sign and verify them, but we should also support them in copy, clean, and any other commands.

@sambhav
Copy link
Contributor

sambhav commented Sep 6, 2021

Wanted to help out with this.

Started with triangulate in #628 for attestations and SBOMs.

I had a couple of questions as I proceed further. The current cosign commands can be a bit confusing for a first time user.

upload/download/attach/attest - looks like upload allows you to upload random artifacts but download only allows you to download related attachments (only signature and sbom). attest which looks very similar to the other attachments has its own set of commands. Should we try and unify this? I assume there is a reason for this structure but its hard to guess without historical context.

copy/clean - How should we specify the flags to copy specific things. Currently copy has a sig-only flag, I guess we need something generic. Should we deprecate the -sig-only flag and add something generic?

Recursive copy and clean - I guess a user may want to copy/clean over all the cosign related references recursively. Should we support this?

@sambhav
Copy link
Contributor

sambhav commented Sep 6, 2021

Would we also want to sign signatures or attestations and similarly verify their signatures? Or is it just massive overkill ? :P

@dlorenc
Copy link
Member Author

dlorenc commented Sep 7, 2021

Should we try and unify this? I assume there is a reason for this structure but its hard to guess without historical context.

Unifying makes sense. Not too much thought got put into these. LMK if you come up with something better.

Would we also want to sign signatures or attestations and similarly verify their signatures? Or is it just massive overkill ? :P

Hah, I think leaving them off is fine. You can always manually sign a signature/attestation with a triangulate call first.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants