Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print cert-extensions if any in verification message #1989

Closed
developer-guy opened this issue Jun 10, 2022 · 3 comments
Closed

print cert-extensions if any in verification message #1989

developer-guy opened this issue Jun 10, 2022 · 3 comments
Assignees
@developer-guy
Labels
enhancement New feature or request

Comments

@developer-guy
Copy link
Member

developer-guy commented Jun 10, 2022 •
edited
Loading

Description

In the PrintVerification function, we do not print the cert extensions to the output, it'd be nice to print them if we have any.

Source👇

cosign/cmd/cosign/cli/verify/verify.go

Line 237 in 68e8d93

func PrintVerification(imgRef string, verified []oci.Signature, output string) {

@developer-guy developer-guy added the enhancement New feature or request label Jun 10, 2022
@developer-guy developer-guy self-assigned this Jun 10, 2022
This was referenced Jun 12, 2022
Closed
Merged
@chipzoller
Copy link

Closed in #1626 ?

@developer-guy
Copy link
Member Author

Closed in #1626 ?

Yep, closed with #1626

@developer-guy
Copy link
Member Author

Thanks @chipzoller for bringing this into my attention 🙋🏻‍♂️

@developer-guy developer-guy mentioned this issue Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@developer-guy developer-guy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@developer-guy @chipzoller