Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosigned] Enforce authority key errors #1642

Closed
DennyHoang opened this issue Mar 21, 2022 · 2 comments
Closed

[cosigned] Enforce authority key errors #1642

DennyHoang opened this issue Mar 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@DennyHoang
Copy link
Contributor

DennyHoang commented Mar 21, 2022

Description

With the implementation of #1623, we currently only warn on errors and do not actually error out when there are issues with getting and using authority keys so that it does not introduce breaking behavior.

When we enforce the new clusterimagepolicy resource and the authority keys, we should update these lines to add to errs instead of a Warn log.

Tracking that we should enforce fail on errors once full migration to using clusterimagepolicy is done.

cc: @hectorj2f @vaikas

@DennyHoang DennyHoang added the enhancement New feature or request label Mar 21, 2022
@hectorj2f
Copy link
Contributor

@DennyHoang I am not sure. Why don't we attempt to parse the content of KeyRef.Data into a ecdsa.PublicKey when creating/update the ClusterImagePolicy resource ? That way we won't need to parse it when validating every single PodSpec.

@DennyHoang
Copy link
Contributor Author

Closing.
Issue is no longer a problem as errors are propagated up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants