Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign cosign release images against Fulcio #1055

Closed
mattmoor opened this issue Nov 15, 2021 · 6 comments · Fixed by #1073
Closed

Sign cosign release images against Fulcio #1055

mattmoor opened this issue Nov 15, 2021 · 6 comments · Fixed by #1073
Labels
enhancement New feature or request

Comments

@mattmoor
Copy link
Member

Description

I was demoing https://chainguard.dev/posts/2021-11-03-zero-friction-keyless-signing with cosigned enabled, and it didn't let the cosign release container through because it wasn't signed against Fulcio 🤦

We should start signing the images we release against Fulcio as well as with the stuff in KMS.

cc @cpanato @dlorenc

@mattmoor mattmoor added the enhancement New feature or request label Nov 15, 2021
@cpanato
Copy link
Member

cpanato commented Nov 16, 2021

@mattmoor should we use GitHub actions with a workflow dispatch to run the releases instead of cloudbuild or we should see how to get a token in cloudbuild? what are your thoughts on this?

and if we use keyless do we need to keep signing with KMS as well?

@mattmoor
Copy link
Member Author

Sorry I thought I replied to this earlier. @dlorenc did this in cloudbuild for distroless, so we can continue doing this there with a little help from an admin on that project to set up IAM.

https://github.com/GoogleContainerTools/distroless/blob/b654a39142a2f21119ad5ad8db6fd86eac204550/cloudbuild.yaml#L82

@cpanato
Copy link
Member

cpanato commented Nov 17, 2021

ok, I think I don't have that permission.

@dlorenc would you mind setting up that and sharing the service account

also to learn that, if you can share the steps to set up that will be great as well, then I can do the same in my rehearsal account to try out

@dlorenc
Copy link
Member

dlorenc commented Nov 17, 2021

Sorry - which project is this again? The GCP project that the cosign release images are hosted inside of?

@dlorenc
Copy link
Member

dlorenc commented Nov 17, 2021

I think we should be good to go with keyless@projectsigstore.iam.gserviceaccount.com now!

@cpanato
Copy link
Member

cpanato commented Nov 17, 2021

cool thanks
i will do the same in my account to make a rehearsal and then update upstream properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants