Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attestation queues have max size 0 if num validators is < slots_per_epoch #6463

Closed
michaelsproul opened this issue Oct 3, 2024 · 1 comment
Labels
bug Something isn't working test improvement Improve tests v6.0.0 New major release for hierarchical state diffs

Comments

@michaelsproul
Copy link
Member

Description

This code will set the maximum size of the attestation queue to 0 if active_validator_count is less than slots_per_epoch. We should probably add a minimum queue size for especially small networks. Maybe 16-32.

// Capacity for a full slot's worth of attestations if subscribed to all subnets
attestation_queue: active_validator_count / slots_per_epoch,
// Capacity for a full slot's worth of attestations if subscribed to all subnets
unknown_block_attestation_queue: active_validator_count / slots_per_epoch,

Version

v5.2.0 onwards.

@michaelsproul michaelsproul added bug Something isn't working test improvement Improve tests v6.0.0 New major release for hierarchical state diffs labels Oct 3, 2024
@michaelsproul
Copy link
Member Author

Bug introduced in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test improvement Improve tests v6.0.0 New major release for hierarchical state diffs
Projects
None yet
Development

No branches or pull requests

1 participant