Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move RuntimeVariableList to ssz_types #5045

Open
realbigsean opened this issue Jan 8, 2024 · 0 comments
Open

Move RuntimeVariableList to ssz_types #5045

realbigsean opened this issue Jan 8, 2024 · 0 comments
Labels
code-quality

Comments

@realbigsean
Copy link
Member

Description

This PR revealed a need for something like RuntimeVariableList in lighthouse #4841

Seems likely other users of ssz_types may run into similar situations, so we could make RuntimeVariableList more broadly available by moving it there.

If we decide to migrate it, we should:

  • implement Arbitrary and TreeHash
  • maybe add more convenience trait impls (IntoIterator,TryFromIterator, Deref, DerefMut, Index, IndexMut, From<Vec>)
  • more tests for any new trait impls
  • add comprehensive documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@realbigsean