From 650abc3de58fcfce92a262b7b581eb507d4ab5c0 Mon Sep 17 00:00:00 2001 From: ohager Date: Mon, 22 Apr 2024 09:01:02 -0300 Subject: [PATCH] chore: marked indirect_incoming stuff as buggy...solving in next PR --- src/brs/db/sql/SqlBlockchainStore.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/brs/db/sql/SqlBlockchainStore.java b/src/brs/db/sql/SqlBlockchainStore.java index 2cbb7628e..dcdfcdb71 100644 --- a/src/brs/db/sql/SqlBlockchainStore.java +++ b/src/brs/db/sql/SqlBlockchainStore.java @@ -182,6 +182,8 @@ public Collection getTransactions(Account account, int numberOfConf ); if (includeIndirectIncoming) { + + // FIXME: this needs to be reviewed, as it does not deliver 100% correct results. int blockTimeStampHeight = getHeightForBlockTimeStamp(blockTimestamp); SelectLimitPercentStep> indirectIncomings = ctx .select(INDIRECT_INCOMING.TRANSACTION_ID) @@ -269,6 +271,7 @@ public Collection getTransactions(Long senderId, Long recipientId, // makes only sense if for recipient. Sender is implicitely included. if (!bidirectional && hasRecipient) { + // FIXME: this needs to be reviewed, as it does not deliver 100% correct results. int blockTimeStampHeight = getHeightForBlockTimeStamp(blockTimestamp); SelectLimitPercentStep> indirectIncomingsForRecipient = ctx .select(INDIRECT_INCOMING.TRANSACTION_ID) @@ -287,6 +290,7 @@ public Collection getTransactions(Long senderId, Long recipientId, } if (bidirectional) { + // FIXME: this needs to be reviewed, as it does not deliver 100% correct results. int blockTimeStampHeight = getHeightForBlockTimeStamp(blockTimestamp); SelectLimitPercentStep> indirectIncomingsForBidirectional = ctx .select(INDIRECT_INCOMING.TRANSACTION_ID)