Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add r wrapper function to run python validation #9

Closed
vpnagraj opened this issue Jan 4, 2021 · 3 comments
Closed

add r wrapper function to run python validation #9

vpnagraj opened this issue Jan 4, 2021 · 3 comments
Assignees

Comments

@vpnagraj
Copy link
Contributor

vpnagraj commented Jan 4, 2021

see #6

this function should wrap the validation .py script provided by C19FH:

https://github.com/reichlab/covid19-forecast-hub/blob/master/code/validation/test_formatting.py

we can call it with a system() command or reticulate (eventually?)

@vpnagraj
Copy link
Contributor Author

vpnagraj commented Jan 5, 2021

@vpnagraj
Copy link
Contributor Author

vpnagraj commented Jan 5, 2021

required python pkgs per https://github.com/reichlab/covid19-forecast-hub/blob/master/visualization/requirements.txt

pandas
requests
pymmwr
click
urllib3
selenium
webdriver-manager
pyyaml
PyGithub
git+https://github.com/reichlab/zoltpy/
https://github.com/hannanabdul55/pykwalify/archive/master.zip

@vpnagraj
Copy link
Contributor Author

vpnagraj commented Jan 5, 2021

the functionality from validate_single_forecast_file.py is now implemented in two ways:

  1. by calling the python script directly from the root of this repo
  2. by using the new validate_forecast() R wrapper

digging in here and basically all that the single forecast vaildation script did was call a function from single py module (zoltpy). that was made it very easy to wrap in a function and call using reticulate.

there is more to validation though ... the other python scripts that C19FH maintains (and are now pulled into the misc/validation dir in this repo) do things like checking metadata files, looping over many forecast files, etc.

there are also the R scripts (no longer maintained by C19FH?) but pulled over and working (for now?) in this repo

we can revisit validation workflows later. for now, this wrapper function works to make sure the quantile csv format is not broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant