Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom error message for dependentValidate error #114

Closed
Sheikh566 opened this issue Mar 2, 2023 · 8 comments
Closed

Custom error message for dependentValidate error #114

Sheikh566 opened this issue Mar 2, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@Sheikh566
Copy link

When dependentValidate() fails, it sets the error message from validateError() function given. But instead it should have its own error handler dependentValidateError() to show more precisely what is wrong.

@Sheikh566
Copy link
Author

If this is a valid feature request. Please assign it to me

@shystruk shystruk added the enhancement New feature or request label Mar 2, 2023
@shystruk
Copy link
Owner

shystruk commented Mar 2, 2023

go ahead and add updates @Sheikh566
thanks for contributing

@Sheikh566
Copy link
Author

Sheikh566 commented Mar 4, 2023

@shystruk I am unable to run test. Getting this error:

node:internal/modules/cjs/loader:988
  throw err;
  ^

Error: Cannot find module 'D:\Study\Self-Learn\OpenSource\csv-file-validator\node'
    at Module._resolveFilename (node:internal/modules/cjs/loader:985:15)
    at Module._load (node:internal/modules/cjs/loader:833:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:23:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v18.10.0
----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |        0 |        0 |        0 |        0 |                   |
----------|----------|----------|----------|----------|-------------------|

Do you know how I can fix it?

@Sheikh566 Sheikh566 reopened this Mar 4, 2023
@shystruk
Copy link
Owner

@Sheikh566 can you please push your branch and I will check what the issue is with tests

@Sheikh566
Copy link
Author

@shystruk Can you add this repo to hacktoberfest 2023?

@shystruk
Copy link
Owner

shystruk commented Oct 1, 2023

@Sheikh566 share the link please

@Sheikh566
Copy link
Author

@shystruk just add hacktoberfest tag to the repo

@shystruk
Copy link
Owner

closed in #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants