From 4a8b3c84475f59b4db56249999eca497b9648fa3 Mon Sep 17 00:00:00 2001 From: Shubham Atlani Date: Thu, 27 Dec 2018 21:56:56 +0530 Subject: [PATCH] Address review comments - replace for loop with stream (#4539) --- .../java/org/jabref/model/groups/WordKeywordGroup.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/main/java/org/jabref/model/groups/WordKeywordGroup.java b/src/main/java/org/jabref/model/groups/WordKeywordGroup.java index 0fd1ae22ec2..35a5912c332 100644 --- a/src/main/java/org/jabref/model/groups/WordKeywordGroup.java +++ b/src/main/java/org/jabref/model/groups/WordKeywordGroup.java @@ -1,7 +1,6 @@ package org.jabref.model.groups; import java.util.ArrayList; -import java.util.Arrays; import java.util.Collection; import java.util.Collections; import java.util.HashSet; @@ -9,6 +8,7 @@ import java.util.Objects; import java.util.Optional; import java.util.Set; +import java.util.stream.Collectors; import org.jabref.model.EntryTypes; import org.jabref.model.FieldChange; @@ -119,11 +119,9 @@ public boolean contains(BibEntry entry) { private Set getFieldContentAsWords(BibEntry entry) { if (onlySplitWordsAtSeparator) { if (BibEntry.TYPE_HEADER.equals(searchField)) { - for (String searchWord : searchWords) { - Optional entryType = EntryTypes.getType(entry.getType(), BibDatabaseMode.BIBLATEX); - if (entryType.isPresent() && entryType.get().getName().equals(searchWord)) { - return new HashSet<>(Arrays.asList(searchWord)); - } + Optional entryType = EntryTypes.getType(entry.getType(), BibDatabaseMode.BIBLATEX); + if (entryType.isPresent()) { + return searchWords.stream().filter(sw -> entryType.get().getName().equals(sw)).collect(Collectors.toSet()); } } return entry.getField(searchField)