From 99a3d90310f9a0a2d551476aae78a0db44ffdbee Mon Sep 17 00:00:00 2001 From: nilsreichardt Date: Fri, 8 Sep 2023 18:45:54 +0200 Subject: [PATCH 1/2] fix(shorebird_cli): suggest to go to "https://console.shorebird.dev" to create an account --- packages/shorebird_cli/lib/src/commands/login_ci_command.dart | 2 +- packages/shorebird_cli/lib/src/shorebird_validator.dart | 2 +- .../shorebird_cli/test/src/commands/login_ci_command_test.dart | 2 +- packages/shorebird_cli/test/src/shorebird_validator_test.dart | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/shorebird_cli/lib/src/commands/login_ci_command.dart b/packages/shorebird_cli/lib/src/commands/login_ci_command.dart index d0c95af22..61b54cb83 100644 --- a/packages/shorebird_cli/lib/src/commands/login_ci_command.dart +++ b/packages/shorebird_cli/lib/src/commands/login_ci_command.dart @@ -28,7 +28,7 @@ class LoginCiCommand extends ShorebirdCommand { We could not find a Shorebird account for ${error.email}.''', ) ..info( - """If you have not yet created an account, you can do so by running "${lightCyan.wrap('shorebird account create')}". If you believe this is an error, please reach out to us via Discord, we're happy to help!""", + """If you have not yet created an account, you can go to "${lightCyan.wrap('https://console.shorebird.dev')}" create on. If you believe this is an error, please reach out to us via Discord, we're happy to help!""", ); return ExitCode.software.code; } catch (error) { diff --git a/packages/shorebird_cli/lib/src/shorebird_validator.dart b/packages/shorebird_cli/lib/src/shorebird_validator.dart index 58b9371dc..c3b31837c 100644 --- a/packages/shorebird_cli/lib/src/shorebird_validator.dart +++ b/packages/shorebird_cli/lib/src/shorebird_validator.dart @@ -68,7 +68,7 @@ class ShorebirdValidator { '''If you already have an account, run ${lightCyan.wrap('shorebird login')} to sign in.''', ) ..info( - '''If you don't have a Shorebird account, run ${lightCyan.wrap('shorebird account create')} to create one.''', + '''If you don't have a Shorebird account, go to ${lightCyan.wrap('https://console.shorebird.dev')} to create one.''', ); throw UserNotAuthorizedException(); } diff --git a/packages/shorebird_cli/test/src/commands/login_ci_command_test.dart b/packages/shorebird_cli/test/src/commands/login_ci_command_test.dart index 9efccc867..8b05d2514 100644 --- a/packages/shorebird_cli/test/src/commands/login_ci_command_test.dart +++ b/packages/shorebird_cli/test/src/commands/login_ci_command_test.dart @@ -56,7 +56,7 @@ void main() { () => logger.err('We could not find a Shorebird account for $email.'), ).called(1); verify( - () => logger.info(any(that: contains('shorebird account create'))), + () => logger.info(any(that: contains('https://console.shorebird.dev'))), ).called(1); }); diff --git a/packages/shorebird_cli/test/src/shorebird_validator_test.dart b/packages/shorebird_cli/test/src/shorebird_validator_test.dart index 24be3b7c5..ffa05396c 100644 --- a/packages/shorebird_cli/test/src/shorebird_validator_test.dart +++ b/packages/shorebird_cli/test/src/shorebird_validator_test.dart @@ -101,7 +101,7 @@ void main() { '''If you already have an account, run ${lightCyan.wrap('shorebird login')} to sign in.''', ), () => logger.info( - '''If you don't have a Shorebird account, run ${lightCyan.wrap('shorebird account create')} to create one.''', + '''If you don't have a Shorebird account, go to ${lightCyan.wrap('https://console.shorebird.dev')} to create one.''', ), ]); }); From 44414fdeef84acd0dc2c4b7c0b1a678d3145617c Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Fri, 8 Sep 2023 16:13:49 -0500 Subject: [PATCH 2/2] apply suggestions --- packages/shorebird_cli/lib/src/commands/login_ci_command.dart | 2 +- packages/shorebird_cli/lib/src/shorebird_validator.dart | 2 +- packages/shorebird_cli/test/src/shorebird_validator_test.dart | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/shorebird_cli/lib/src/commands/login_ci_command.dart b/packages/shorebird_cli/lib/src/commands/login_ci_command.dart index 61b54cb83..f8c1aaed3 100644 --- a/packages/shorebird_cli/lib/src/commands/login_ci_command.dart +++ b/packages/shorebird_cli/lib/src/commands/login_ci_command.dart @@ -28,7 +28,7 @@ class LoginCiCommand extends ShorebirdCommand { We could not find a Shorebird account for ${error.email}.''', ) ..info( - """If you have not yet created an account, you can go to "${lightCyan.wrap('https://console.shorebird.dev')}" create on. If you believe this is an error, please reach out to us via Discord, we're happy to help!""", + '''If you have not yet created an account, go to "${link(uri: Uri.parse('https://console.shorebird.dev'))}" to create one. If you believe this is an error, please reach out to us via Discord, we're happy to help!''', ); return ExitCode.software.code; } catch (error) { diff --git a/packages/shorebird_cli/lib/src/shorebird_validator.dart b/packages/shorebird_cli/lib/src/shorebird_validator.dart index c3b31837c..8cd7c4a53 100644 --- a/packages/shorebird_cli/lib/src/shorebird_validator.dart +++ b/packages/shorebird_cli/lib/src/shorebird_validator.dart @@ -68,7 +68,7 @@ class ShorebirdValidator { '''If you already have an account, run ${lightCyan.wrap('shorebird login')} to sign in.''', ) ..info( - '''If you don't have a Shorebird account, go to ${lightCyan.wrap('https://console.shorebird.dev')} to create one.''', + '''If you don't have a Shorebird account, go to ${link(uri: Uri.parse('https://console.shorebird.dev'))} to create one.''', ); throw UserNotAuthorizedException(); } diff --git a/packages/shorebird_cli/test/src/shorebird_validator_test.dart b/packages/shorebird_cli/test/src/shorebird_validator_test.dart index ffa05396c..028659dd7 100644 --- a/packages/shorebird_cli/test/src/shorebird_validator_test.dart +++ b/packages/shorebird_cli/test/src/shorebird_validator_test.dart @@ -101,7 +101,7 @@ void main() { '''If you already have an account, run ${lightCyan.wrap('shorebird login')} to sign in.''', ), () => logger.info( - '''If you don't have a Shorebird account, go to ${lightCyan.wrap('https://console.shorebird.dev')} to create one.''', + '''If you don't have a Shorebird account, go to ${link(uri: Uri.parse('https://console.shorebird.dev'))} to create one.''', ), ]); });