Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: next_patch endpoint returns false if the latest patch does not have an artifact for that platform #753

Closed
eseidel opened this issue Jul 1, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@eseidel
Copy link
Contributor

eseidel commented Jul 1, 2023

shorebird release android
shorebird release ios
shorebird patch android
shorebird patch ios

Your android clients will now refuse to update to patch #1 because patch #2 exists that doesn't have an android artifact.

The fact that these two patches are separate is also an issue, tracked by: #752

But both of these need fixing I believe?

@eseidel eseidel added the bug Something isn't working label Jul 1, 2023
@eseidel
Copy link
Contributor Author

eseidel commented Jul 1, 2023

I suspect this could also manifest if you started a patch update but then aborted at a bad time? You could end up with a new patch N created that didn't yet have an android artifact uploaded and your android clients would then refuse to update to N-1?

Presumably this needs to be a bit smarter?
https://github.com/shorebirdtech/_shorebird/blob/main/packages/code_push_server/routes/api/v1/patches/check.dart#L106

@felangel felangel self-assigned this Jul 2, 2023
@felangel felangel moved this to In Progress in fluttercon Jul 2, 2023
@felangel felangel closed this as completed Jul 5, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in fluttercon Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants