Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iOS release builds should run at full speed #673

Closed
eseidel opened this issue Jun 16, 2023 · 1 comment
Closed

feat: iOS release builds should run at full speed #673

eseidel opened this issue Jun 16, 2023 · 1 comment
Labels

Comments

@eseidel
Copy link
Contributor

eseidel commented Jun 16, 2023

Right now shorebird release ios builds run about 10x slower than necessary.

This is because we compile with DART_SIMULATOR on always.

The fix is to make DART_SIMULATOR a runtime switch instead of a compile time switch. The simulator is only needed as part of running patched builds (and can be made much faster).

@eseidel
Copy link
Contributor Author

eseidel commented Sep 5, 2023

We've decided to fix this by just fixing #674 instead. That will avoid us having two separate modes.

@eseidel eseidel closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant