Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shorebird cli should support windows #37

Closed
3 tasks done
felangel opened this issue Mar 7, 2023 · 6 comments · Fixed by shorebirdtech/install#13
Closed
3 tasks done

shorebird cli should support windows #37

felangel opened this issue Mar 7, 2023 · 6 comments · Fixed by shorebirdtech/install#13
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@felangel
Copy link
Contributor

felangel commented Mar 7, 2023

Currently the shorebird tooling only works on MacOS (because of the shorebird engine).

Todo

  • build different versions of the shorebird engine for each platform/arch
  • pull the correct engine based on the host platform
  • proxy to Flutter with the correct args/paths
@felangel felangel converted this from a draft issue Mar 7, 2023
@felangel felangel added the enhancement New feature or request label Mar 7, 2023
@eseidel
Copy link
Contributor

eseidel commented Mar 16, 2023

This is blocked by #56 as it will be really hard to maintain multiple platforms w/o some form of automation.

@eseidel
Copy link
Contributor

eseidel commented Apr 7, 2023

We believe linux now works, but need to test. Windows is missing an installer. Interesting to note that Rust doesn't use a curl | sh method on windows (perhaps there is no equivalent):
https://forge.rust-lang.org/infra/other-installation-methods.html

@eseidel
Copy link
Contributor

eseidel commented Apr 7, 2023

The big thing missing from Windows is a shorebird.bat (or shorebird.ps1?) like Flutter's:
https://github.com/flutter/flutter/blob/master/bin/flutter.bat

@eseidel
Copy link
Contributor

eseidel commented Apr 7, 2023

@eseidel eseidel moved this to Unsorted in 0.0.8: adding more TTs Apr 18, 2023
@eseidel eseidel changed the title shorebird cli should support windows and linux shorebird cli should support windows Apr 18, 2023
@eseidel
Copy link
Contributor

eseidel commented Apr 18, 2023

Looking through shorebird_cli we have runInShell sprinkled in various places. I suspect we need to centralize that handling (in part to deal with Windows).

@bryanoltman
Copy link
Contributor

#369 makes an already-installed shorebird work in powershell. I think the only remaining task is the installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants