Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shorebird preview doesn't think I'm inside a project #1836

Closed
eseidel opened this issue Mar 28, 2024 · 1 comment · Fixed by #1854
Closed

fix: shorebird preview doesn't think I'm inside a project #1836

eseidel opened this issue Mar 28, 2024 · 1 comment · Fixed by #1854
Assignees
Labels
good first issue Good for newcomers

Comments

@eseidel
Copy link
Contributor

eseidel commented Mar 28, 2024

Running here:
https://github.com/shorebirdtech/samples/tree/main/flavors

PS C:\Users\micro\Documents\GitHub\samples\flavors> ..\..\shorebird\bin\shorebird preview
✓ Fetching apps (0.3s)
Which app would you like to preview?
❯ ◉  test_shorebird
  ◯  fresh_example
  ◯  fresh_dio
  ◯  openreads
  ◯  flutter_amazon_clone_bloc
  ◯  buck_the_critics
  ◯  test_3_16_4
  ◯  test_ios_mix
  ◯  flutter_and_friends
  ◯  fluttersaurus
  ◯  test_3_16_3
  ◯  flavors (stable)
  ◯  flavors (internal)
  ◯  flavors (stable)
  ◯  flavors (internal)
  ◯  test_3_13_9
  ◯  test_3_13_9
  ◯  mixed_test
  ◯  lima_test
  ◯  test_3_13_8
  ◯  flavors (stable)
  ◯  flavors (internal)
  ◯  test_3_13_4
  ◯  test_0_14_8
  ◯  test_0_14_7
  ◯  test_no_android
  ◯  shorebird_code_push_example
  ◯  test_3_13_1
  ◯  my_project
  ◯  test_counter
  ◯  time_shift
  ◯  shorebird_code_push
  ◯  fluttercon_demo
  ◯  ios_test
  ◯  test_app
  ◯  shorebird_hello
  ◯  hello_shorebird
  ◯  win_test
@eseidel
Copy link
Contributor Author

eseidel commented Mar 28, 2024

We're jsut missing a "prompt for flavor" codepath:

 final shorebirdYaml = shorebirdEnv.getShorebirdYaml();
    final String? appId;
    if (results.wasParsed('app-id')) {
      appId = results['app-id'] as String;
    } else if (shorebirdYaml != null && shorebirdYaml.flavors == null) {
      appId = shorebirdYaml.appId;
    } else {
      appId = await promptForApp();
    }

@eseidel eseidel added the good first issue Good for newcomers label Mar 29, 2024
@eseidel eseidel added this to 1.1 Mar 29, 2024
@eseidel eseidel moved this to Todo in 1.1 Apr 2, 2024
@erickzanardo erickzanardo self-assigned this Apr 2, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in 1.1 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants