Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to Dart 3.3.0 and Flutter 3.19.0 #1723

Closed
eseidel opened this issue Feb 9, 2024 · 9 comments
Closed

feat: upgrade to Dart 3.3.0 and Flutter 3.19.0 #1723

eseidel opened this issue Feb 9, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@eseidel
Copy link
Contributor

eseidel commented Feb 9, 2024

Dart 3.3.0 just appeared on stable this morning:
https://github.com/dart-lang/sdk/tree/stable

My sense from experience is that that means Flutter isn't far behind.

We're blocked on fixing #1698 due to dart-lang/sdk#54860 affecting .dill generation, which we currently use upstream Dart for (not our fork). It would take a bunch of work for us to modify our infrastructure (and Dart code) to vend a patched dart binary (we don't test our modified Dart in JIT mode at all currently), so instead we're going to start the upgrade.

Steps I can see:

  • Upgrade dart
  • Upgrade build_root
  • Upgrade flutter/engine
  • Upgrade flutter/flutter

There will probably be a bunch of infra/tooling work relating to flutter/engine having moved to use signing for iOS. We may also need to request a cert from Apple.

@eseidel eseidel added the bug Something isn't working label Feb 9, 2024
@eseidel eseidel added this to 1.0 Feb 9, 2024
@eseidel eseidel moved this to Todo in 1.0 Feb 9, 2024
@eseidel
Copy link
Contributor Author

eseidel commented Feb 9, 2024

@eseidel
Copy link
Contributor Author

eseidel commented Feb 9, 2024

Flutter Beta:
Flutter: b7e7d46a046ba8a22897a514bf2311a0f81ab198
Engine: 98820f0a7716715df150f6adc5edd3444a088196
Dart: fe4b8016416d22afe75d8225f0c3f753b089c0b1
BuildRoot: 0141e94b34cbd3db77f28796587334857fa985da

@eseidel
Copy link
Contributor Author

eseidel commented Feb 9, 2024

Cutler agrees:

 dart run bin/cutler.dart  versions --repo=flutter b7e7d46a046ba8a22897a514bf2311a0f81ab198
Using /Users/eseidel/Documents/GitHub as checkouts root.
✓ Checkouts updated! (6.7s)
Flutter b7e7d46a046ba8a22897a514bf2311a0f81ab198:
  flutter   b7e7d46a046ba8a22897a514bf2311a0f81ab198 (3.19.0-0.4.pre)
  engine    98820f0a7716715df150f6adc5edd3444a088196 (3.19.0-0.4.pre)
  dart      fe4b8016416d22afe75d8225f0c3f753b089c0b1 (3.3.0-279.3.beta)
  buildroot 0141e94b34cbd3db77f28796587334857fa985da

@eseidel
Copy link
Contributor Author

eseidel commented Feb 10, 2024

Smoke test notes:

@eseidel
Copy link
Contributor Author

eseidel commented Feb 12, 2024

We decided to release this as a flutter-only release (no shorebird change) for now to avoid encouraging all of our customers to switch to the beta channel, only to have to switch back to stable again soon.

@eseidel eseidel moved this from Todo to In Progress in 1.0 Feb 12, 2024
@felangel
Copy link
Contributor

See #1698 (comment) for more info.

@eseidel
Copy link
Contributor Author

eseidel commented Feb 15, 2024

Flutter 3.19.0:
  flutter   bae5e49bc2a867403c43b2aae2de8f8c33b037e4 (3.19.0)
  engine    04817c99c9fd4956f27505204f7e344335810aed (3.19.0)
  dart      25b3f65bf6264df5bd7cd6aca25cb68d47b9348b
  buildroot 0141e94b34cbd3db77f28796587334857fa985da

@eseidel
Copy link
Contributor Author

eseidel commented Feb 15, 2024

@eseidel
Copy link
Contributor Author

eseidel commented Feb 15, 2024

dart run bin/cutler.dart validate 3.19.0
Using /Users/eseidel/Documents/GitHub as checkouts root.
✓ Checkouts updated! (16.6s)
Validating 3.19.0
✅ flutter    refs/tags/3.19.0 matches upstream bae5e49bc2a867403c43b2aae2de8f8c33b037e4 (refs/tags/3.19.0)
✅ engine     refs/tags/3.19.0 matches upstream 04817c99c9fd4956f27505204f7e344335810aed (refs/tags/3.19.0)
✅ buildroot  correctly branched
✅ dart       correctly branched
✅ engine     correctly branched
✅ flutter    correctly branched

@eseidel eseidel closed this as completed Feb 15, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 1.0 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants