Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shorebird hangs when run under fastlane #1705

Closed
eseidel opened this issue Feb 6, 2024 · 10 comments · Fixed by #1845
Closed

fix: shorebird hangs when run under fastlane #1705

eseidel opened this issue Feb 6, 2024 · 10 comments · Fixed by #1845
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@eseidel
Copy link
Contributor

eseidel commented Feb 6, 2024

"""
I included the shorebird command in my fastlane pipeline for ease of use and this is where it never continues after it packages everything up. I then tried running the command outside of fastlane (thinking it might be some directory issue, it occured in the past with different tools), and that's when I found out why it never finished via fastlane. Shorebird asks you if you want to create a new release ("Would you like to continue?"), and that question is not visible if you run the command via fastlane. So just had to add the --force command for the release build that I was doing via fastlane and everything works. 😂
"""

  1. We should detect this case (fastlane is pretty common, or was at one point). And presumably we're headless in that environment (don't have a TERM?)
  2. We should discourage use of --force and instead some sort of --no-confirm flag for situations like this we can't detect.
@eseidel eseidel added the bug Something isn't working label Feb 6, 2024
@eseidel eseidel added the good first issue Good for newcomers label Mar 29, 2024
@eseidel
Copy link
Contributor Author

eseidel commented Mar 29, 2024

I think the right thing here is for us (or mason_logger) to detect that it's running headless and never hang in confirm.

@eseidel eseidel added this to 1.0 Mar 29, 2024
@eseidel eseidel moved this to Customers in 1.0 Mar 29, 2024
@eseidel
Copy link
Contributor Author

eseidel commented Mar 29, 2024

Got another report of this just now with #1841.

Does anyone know of an example project using fastlane with Flutter that we should work from?

Otherwise I guess we can build one from https://docs.flutter.dev/deployment/cd#fastlane

@eseidel
Copy link
Contributor Author

eseidel commented Mar 29, 2024

A workaround for now could be to run:

yes | shorebird release android

since yes will send "y" any time prompted.

@bryanoltman bryanoltman self-assigned this Apr 1, 2024
@bryanoltman bryanoltman moved this from Customers to In Progress in 1.0 Apr 1, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 1.0 Apr 1, 2024
@vivaan-vama
Copy link

Any update on this ?

@bryanoltman
Copy link
Contributor

A fix has been merged to our main branch and will go out in the next release (today or tomorrow)

@vivaan-vama
Copy link

Thanks for the update! can you confirm what steps we need to take to auto confirm ?

@bryanoltman
Copy link
Contributor

None, you will just need to update to the latest version when we release.

@bryanoltman
Copy link
Contributor

In the meantime, you can set CI=true as an environment variable and it will have the same effect as the new version. Once the new version is released, the environment variable won't be necessary.

@vivaan-vama
Copy link

Hi, Have you deployed the new release, if yes what exactly i have to pass now ?

@bryanoltman
Copy link
Contributor

This has been deployed. It should just work with no changes on your side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
Status: Done
3 participants