Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unpatched builds are slower than patched builds on iOS #1661

Closed
eseidel opened this issue Jan 23, 2024 · 3 comments
Closed

fix: Unpatched builds are slower than patched builds on iOS #1661

eseidel opened this issue Jan 23, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@eseidel
Copy link
Contributor

eseidel commented Jan 23, 2024

Originally when implementing mixed-mode, we decided that the "off" behavior should be to run everything within the interpreter to minimize surprises for customers of their app running much slower after patching.

Of course, now that we've made mixed mode fast(er) now patching with an empty patch can end up causing the app to run much faster than unpatched.

#674

This is silly, and should be relatively easy to fix in our Dart runtime. It will then make it the case that patching can cause a slowdown of your app, but since that slowdown should be much smaller than before that seems like the correct behavior.

@eseidel eseidel added the bug Something isn't working label Jan 23, 2024
@eseidel
Copy link
Contributor Author

eseidel commented Jan 23, 2024

In all cases, patched and unpatched builds should now be faster than they were with our old iOS engine (Dec 2023 and before). This bug is about our eventual desire to change unpatched builds to run everything on the CPU (thus making them 100% full speed, but risking users being surprised when patched builds may be slower than unpatched builds).

@eseidel
Copy link
Contributor Author

eseidel commented Jan 23, 2024

https://github.com/shorebirdtech/dart-sdk/issues/284 was filed to cover some of the details of making this work.

@eseidel
Copy link
Contributor Author

eseidel commented Jan 31, 2024

Felix wired this up just now, and will be out in our next release (later today).

@eseidel eseidel closed this as completed Jan 31, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in iOS Beta Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant