Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support renaming Runner.app #1648

Closed
eseidel opened this issue Jan 18, 2024 · 3 comments · Fixed by #1649
Closed

fix: Support renaming Runner.app #1648

eseidel opened this issue Jan 18, 2024 · 3 comments · Fixed by #1649
Labels
blocks customer Known to block at least one large customer

Comments

@eseidel
Copy link
Contributor

eseidel commented Jan 18, 2024

I think we used to support this and it broke?
@eseidel
Copy link
Contributor Author

eseidel commented Jan 18, 2024

e.g.

shorebird/packages/shorebird_cli/lib/src/commands/patch/patch_ios_command.dart

Line 307 in 726dbe1

'Runner.app',

@eseidel eseidel changed the title feat: Support renaming Runner.app fix: Support renaming Runner.app Jan 18, 2024
@eseidel eseidel added the blocks customer Known to block at least one large customer label Jan 18, 2024
@eseidel eseidel added this to iOS Beta Jan 18, 2024
@eseidel eseidel moved this to Todo in iOS Beta Jan 18, 2024
@eseidel
Copy link
Contributor Author

eseidel commented Jan 18, 2024

We also will need to set up a test somewhere so we don't break this again.

@eseidel
Copy link
Contributor Author

eseidel commented Jan 18, 2024

This is another (probably quick fix) if you're looking for things @bryanoltman

@bryanoltman bryanoltman mentioned this issue Jan 18, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in iOS Beta Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocks customer Known to block at least one large customer
Projects
No open projects
iOS Beta
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(shorebird_cli): handle renamed Runner shorebirdtech/shorebird
1 participant
@eseidel