From 2b616c7ac220711a237e41b2442ea761a9645718 Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Wed, 7 Feb 2024 15:53:49 -0800 Subject: [PATCH] fix(shorebird_cli): `shorebird release ios` warns on unknown shorebird flutter versions (#1712) --- .../shorebird_flutter_version_supports_ios_validator.dart | 4 ++-- ...orebird_flutter_version_supports_ios_validator_test.dart | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/shorebird_cli/lib/src/validators/shorebird_flutter_version_supports_ios_validator.dart b/packages/shorebird_cli/lib/src/validators/shorebird_flutter_version_supports_ios_validator.dart index a5f35308b..a6651d34a 100644 --- a/packages/shorebird_cli/lib/src/validators/shorebird_flutter_version_supports_ios_validator.dart +++ b/packages/shorebird_cli/lib/src/validators/shorebird_flutter_version_supports_ios_validator.dart @@ -19,8 +19,8 @@ class ShorebirdFlutterVersionSupportsIOSValidator extends Validator { if (flutterVersion == null) { issues.add( const ValidationIssue( - severity: ValidationIssueSeverity.error, - message: 'Failed to determine Shorebird Flutter version', + severity: ValidationIssueSeverity.warning, + message: 'Unable to determine Shorebird Flutter version', ), ); return issues; diff --git a/packages/shorebird_cli/test/src/validators/shorebird_flutter_version_supports_ios_validator_test.dart b/packages/shorebird_cli/test/src/validators/shorebird_flutter_version_supports_ios_validator_test.dart index 32873d88c..fd5bf0be6 100644 --- a/packages/shorebird_cli/test/src/validators/shorebird_flutter_version_supports_ios_validator_test.dart +++ b/packages/shorebird_cli/test/src/validators/shorebird_flutter_version_supports_ios_validator_test.dart @@ -36,15 +36,15 @@ void main() { when(() => shorebirdFlutter.getVersion()).thenAnswer((_) async => null); }); - test('returns validation error', () async { + test('returns validation warning', () async { final results = await runWithOverrides(validator.validate); expect( results, equals([ const ValidationIssue( - severity: ValidationIssueSeverity.error, - message: 'Failed to determine Shorebird Flutter version', + severity: ValidationIssueSeverity.warning, + message: 'Unable to determine Shorebird Flutter version', ), ]), );