From 41de6f31c399effb14a794869247a8caf7bacb57 Mon Sep 17 00:00:00 2001 From: Bryan Oltman Date: Tue, 16 May 2023 12:01:32 -0400 Subject: [PATCH] chore: better logging when shorebird.yaml is missing (#16) * fix: gracefully handle missing shorebird.yaml asset * format * more formatting * revert changes to flutter_main.cc --- .../android/io/flutter/embedding/engine/FlutterJNI.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java b/shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java index a31a8fa0654c5..4c38ee11316b7 100644 --- a/shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java +++ b/shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java @@ -5,8 +5,8 @@ package io.flutter.embedding.engine; import android.content.Context; -import android.content.pm.PackageManager; import android.content.pm.PackageInfo; +import android.content.pm.PackageManager; import android.content.res.AssetManager; import android.graphics.Bitmap; import android.graphics.ColorSpace; @@ -206,7 +206,8 @@ public void init( String version = null; long versionCode = 0; try { - PackageInfo packageInfo = context.getPackageManager().getPackageInfo(context.getPackageName(), 0); + PackageInfo packageInfo = + context.getPackageManager().getPackageInfo(context.getPackageName(), 0); version = packageInfo.versionName; versionCode = packageInfo.getLongVersionCode(); } catch (PackageManager.NameNotFoundException e) { @@ -225,6 +226,7 @@ public void init( Log.w(TAG, "shorebird.yaml: " + shorebirdYaml); } catch (IOException e) { Log.e(TAG, "Failed to load shorebird.yaml", e); + Log.e(TAG, "Did you remember to include shorebird.yaml in your pubspec.yaml's assets?"); } FlutterJNI.nativeInit(