don't block escape; fixes #1607 (#1661)

shoelace-style · Oct 18, 2023 · a5404ec · a5404ec
1 parent afe7778
commit a5404ec
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/docs/pages/resources/changelog.md b/docs/pages/resources/changelog.md
@@ -15,6 +15,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti
 ## Next
 
 - Added the Croatian translation [#1656]
+- Fixed a bug that caused the [[Escape]] key to stop propagating when tooltips are disabled [#1607]
 
 ## 2.10.0
 

diff --git a/src/components/tooltip/tooltip.component.ts b/src/components/tooltip/tooltip.component.ts
@@ -145,7 +145,7 @@ export default class SlTooltip extends ShoelaceElement {
 
   private handleKeyDown = (event: KeyboardEvent) => {
     // Pressing escape when the target element has focus should dismiss the tooltip
-    if (this.open && event.key === 'Escape') {
+    if (this.open && !this.disabled && event.key === 'Escape') {
       event.stopPropagation();
       this.hide();
     }
-Original file line number
+Diff line change
@@ Expand Up @@
     ## Next
     - Added the Croatian translation [#1656]
+    - Fixed a bug that caused the [[Escape]] key to stop propagating when tooltips are disabled [#1607]
     ## 2.10.0
@@ Expand Down @@