Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support for contextDir in the s2i strategy #638

Closed
qu1queee opened this issue Mar 4, 2021 · 2 comments · Fixed by #760
Closed

Provide support for contextDir in the s2i strategy #638

qu1queee opened this issue Mar 4, 2021 · 2 comments · Fixed by #760
Assignees
@adambkaplan
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
release-v0.5.0

Comments

@qu1queee
Copy link
Contributor

qu1queee commented Mar 4, 2021

Idea:

This is coming from this comment, where when modifying the following build sample we realized that the usage of spec.source.contextDir is not supported in the source-to-image strategy.

@adambkaplan fyi
@qu1queee qu1queee added the kind/bug Categorizes issue or PR as related to a bug. label Mar 4, 2021
@qu1queee qu1queee added this to the release-v0.4.0 milestone Mar 4, 2021
@qu1queee qu1queee mentioned this issue Mar 4, 2021
Merged
4 tasks
@adambkaplan
Copy link
Member

/assign @adambkaplan

@gabemontero
Copy link
Member

We are going to try and cut the v0.4.0 milestone this week. With @adambkaplan being on PTO this won't be getting done in time for that, so I've moved it to v0.5.0

@qu1queee qu1queee mentioned this issue May 4, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adambkaplan adambkaplan

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
release-v0.5.0
Development

Successfully merging a pull request may close this issue.

Add support for contextDir in S2I strategy qu1queee/build
3 participants
@adambkaplan @gabemontero @qu1queee