Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operator-sdk crds generation target #472

Closed
qu1queee opened this issue Nov 9, 2020 · 1 comment
Closed

Add operator-sdk crds generation target #472

qu1queee opened this issue Nov 9, 2020 · 1 comment
Assignees
@qu1queee
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@qu1queee
Copy link
Contributor

qu1queee commented Nov 9, 2020

Idea:

We need to validate that our CRDs are inline with the version of the operator-sdk we have. For this we should do that by reusing the sdk version in the vendor folder, and triggering the generation via a make target file.

Acceptance_Criteria:

  • Generate new make target
  • Ensure binary is build via the vendor dependencies for the sdk
  • Ensure the CRDs generation take place per pr, basically validate if they match the generate ones on the fly from the vendor operator-sdk dependency
@qu1queee qu1queee self-assigned this Nov 9, 2020
@qu1queee qu1queee added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Nov 9, 2020
@qu1queee qu1queee mentioned this issue Nov 9, 2020
Merged
@qu1queee
Copy link
Contributor Author

Closing this in favor of #579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qu1queee qu1queee

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qu1queee