Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test create_and_destroy: Cannot execute null.is holding(). #3530

Closed
github-actions bot opened this issue Oct 11, 2024 · 1 comment · Fixed by #3572
Closed

Flaky test create_and_destroy: Cannot execute null.is holding(). #3530

github-actions bot opened this issue Oct 11, 2024 · 1 comment · Fixed by #3572
Labels
🤖 Flaky Test Report

Comments

@github-actions
Copy link
Contributor

Flaky tests were detected in this test run. This means that there was a failure that was cleared when the tests were simply restarted.
Failures:

create_and_destroy: [2024-10-11 01:46:30] Runtime in code/game/objects/items/devices/mines.dm,383: Cannot execute null.is holding().
proc name: mine effect (/obj/item/mine/pressure/explosive/fire/mine_effect)
src: the G-82 Incindeary (/obj/item/mine/pressure/explosive/fire/live)
src.loc: the floor (5,44,2) (/turf/open/floor/vault)
call stack:
the G-82 Incindeary (/obj/item/mine/pressure/explosive/fire/live): mine effect(null)
the G-82 Incindeary (/obj/item/mine/pressure/explosive/fire/live): blast now(null)
/datum/callback (/datum/callback): InvokeAsync()
Timer (/datum/controller/subsystem/timer): fire(0)
Timer (/datum/controller/subsystem/timer): ignite(0)
Master (/datum/controller/master): RunQueue()
Master (/datum/controller/master): Loop(2)
Master (/datum/controller/master): StartProcessing(0) at code/game/objects/items/devices/mines.dm:383
MarkSuckerberg added a commit to MarkSuckerberg/Shiptest that referenced this issue Oct 16, 2024
@MarkSuckerberg
Fixes Flaky test create_and_destroy: Cannot execute null.is holding(). …
5d5d935 
…shiptest-ss13#3530
@MarkSuckerberg MarkSuckerberg mentioned this issue Oct 16, 2024
Merged
MarkSuckerberg added a commit to MarkSuckerberg/Shiptest that referenced this issue Oct 17, 2024
@MarkSuckerberg
Fixes Flaky test create_and_destroy: Cannot execute null.is holding(). …
23d0f49 
…shiptest-ss13#3530
MarkSuckerberg added a commit to MarkSuckerberg/Shiptest that referenced this issue Oct 22, 2024
@MarkSuckerberg
Fixes Flaky test create_and_destroy: Cannot execute null.is holding(). …
55f07ea 
…shiptest-ss13#3530
MarkSuckerberg added a commit to MarkSuckerberg/Shiptest that referenced this issue Oct 23, 2024
@MarkSuckerberg
Fixes Flaky test create_and_destroy: Cannot execute null.is holding(). …
ed254ee 
…shiptest-ss13#3530
MarkSuckerberg added a commit to MarkSuckerberg/Shiptest that referenced this issue Oct 25, 2024
@MarkSuckerberg
Fixes Flaky test create_and_destroy: Cannot execute null.is holding(). …
5807c03 
…shiptest-ss13#3530
@Sun-Soaked
Copy link
Member

fixed by marg

Erikafox pushed a commit to Erikafox/Shiptest that referenced this issue Oct 25, 2024
@MarkSuckerberg @MrMelbert
@san7890 @PowerfulBacon @Cyberboss @jlsnow301 @distributivgesetz @stylemistake
Opendream-detected Errors, More Harddels, Slight CI Improvements (shi…
c38a3d2 
…ptest-ss13#3572)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
I didn't get them all in my last PR, apparently. Also throws in some
minor tweaks for ambiguity and such detected by the OpenDream parser
since I was messing around with that at the time.

Also adds OpenDream linting to CI because why not.

Ports:
tgstation/tgstation#81892 (which is in turn from Para and Goon)
tgstation/tgstation#82029
BeeStation/BeeStation-Hornet#11464

tgstation/tgstation#86510
tgstation/tgstation#83255
tgstation/tgstation#78225
tgstation/tgstation#78265

Fixes: shiptest-ss13#3530 

## Why It's Good For The Game
Harddels still bad, OpenDream good

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Co-authored-by: Jordan Dominion <Cyberboss@users.noreply.github.com>
Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this issue Oct 29, 2024
@MarkSuckerberg @MrMelbert
@san7890 @PowerfulBacon @Cyberboss @jlsnow301 @distributivgesetz @stylemistake @zimon9
Opendream-detected Errors, More Harddels, Slight CI Improvements (shi…
0e3f7cf 
…ptest-ss13#3572)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
I didn't get them all in my last PR, apparently. Also throws in some
minor tweaks for ambiguity and such detected by the OpenDream parser
since I was messing around with that at the time.

Also adds OpenDream linting to CI because why not.

Ports:
tgstation/tgstation#81892 (which is in turn from Para and Goon)
tgstation/tgstation#82029
BeeStation/BeeStation-Hornet#11464

tgstation/tgstation#86510
tgstation/tgstation#83255
tgstation/tgstation#78225
tgstation/tgstation#78265

Fixes: shiptest-ss13#3530 

## Why It's Good For The Game
Harddels still bad, OpenDream good

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Co-authored-by: Jordan Dominion <Cyberboss@users.noreply.github.com>
Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this issue Dec 27, 2024
@MarkSuckerberg @MrMelbert
@san7890 @PowerfulBacon @Cyberboss @jlsnow301 @distributivgesetz @stylemistake @MrCat15352
Opendream-detected Errors, More Harddels, Slight CI Improvements (shi…
3e84e77 
…ptest-ss13#3572)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
I didn't get them all in my last PR, apparently. Also throws in some
minor tweaks for ambiguity and such detected by the OpenDream parser
since I was messing around with that at the time.

Also adds OpenDream linting to CI because why not.

Ports:
tgstation/tgstation#81892 (which is in turn from Para and Goon)
tgstation/tgstation#82029
BeeStation/BeeStation-Hornet#11464

tgstation/tgstation#86510
tgstation/tgstation#83255
tgstation/tgstation#78225
tgstation/tgstation#78265

Fixes: shiptest-ss13#3530
Harddels still bad, OpenDream good

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Co-authored-by: Jordan Dominion <Cyberboss@users.noreply.github.com>
Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 Flaky Test Report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Opendream-detected Errors, More Harddels, Slight CI Improvements MarkSuckerberg/Shiptest
1 participant
@Sun-Soaked