if should make local variable scope

[yhara]

Given

let a = true
if a                                                                             
  let x = 1
end                                                                              

p x

Expected

Compile error

Actual

Prints 1.

(EXC_BAD_ACCESS if a = false)

Implementation

• Add If(IfCtx) here
• Like convert_while_expr, push and pop ctx in convert_if_expr

[yhara]

I'm considering introducing let keyword like Rust.

[EruEri]

Hi @yhara
I can try to fix this issue ?

[yhara]

@EruEri Yes, please!
@AI-Mozi Please let us know if you have something more to share after the last commit in #447.

[EruEri]

I have something that seems to work.
Can I create the PR ? I also have some questions on whevener or not the IfCtx shound have contain lvars or not

[yhara]

Oh please make a new PR then.
IfCtx should have lvars, like ToplevelCtx/ClassCtx/MethodCtx, etc. does.

[moozzi]

Hey!
I got stuck in a certain place, I don't even remember where 😅
@EruEri go ahead, I hope it goes better for you:)

[yhara]

fixed by #474.