🆕 [ARM/ARM64 users] Feedback on new packages

[shiftkey]

Please submit any feedback you have here about the new ARM and ARM64 installers.

Latest release: 3.2.7-linux2

[isuro]

I'm using it via X11 & Docker, so some limitations apply from not having any real desktop environment or browser, but generally working great.

(Ubuntu 20.04.5 LTS, installed via .deb, current XQuartz & Docker, Macbook Pro M1)

[Lunarequest]

the flatpak now builds for aarch64 as well(flathub doesn't support arm so we haven't build it for it)

[isuro]

Launching from cli no longer works ☹️.
As of 3.2.7-linux2, if I comment out the redirect to /dev/null in /usr/lib/github-desktop/resources/app/static/github, I get:

$ github
ERR! Desktop command line interface not currently supported on platform linux
Error: Desktop command line interface not currently supported on platform linux
    at t (/usr/lib/github-desktop/resources/app/cli.js:1:26473)
    at Object.handler (/usr/lib/github-desktop/resources/app/cli.js:1:26160)
    at h (/usr/lib/github-desktop/resources/app/cli.js:1:28549)
    at e (/usr/lib/github-desktop/resources/app/cli.js:1:28693)
    at /usr/lib/github-desktop/resources/app/cli.js:1:28764
    at /usr/lib/github-desktop/resources/app/cli.js:1:28783
    at Object.<anonymous> (/usr/lib/github-desktop/resources/app/cli.js:1:28808)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1296:10)
    at Module.load (node:internal/modules/cjs/loader:1096:32)

(Ubuntu 20.04.5 LTS, installed via .deb, current XQuartz & Docker, Macbook Pro M1)

[shiftkey]

@isuro which architecture are you installing? That appears to be this error:

desktop/app/src/cli/open-desktop.ts

Lines 20 to 22 in 18c585f

	throw new Error(
	`Desktop command line interface not currently supported on platform ${process.platform}`
	)

But I'm puzzled about how it's reaching there because the __LINUX__ global that we set when building also uses process.platform:

desktop/app/app-info.ts

Line 37 in 18c585f

__LINUX__: process.platform === 'linux',

[isuro]

Installed via GitHubDesktop-linux-arm64-3.2.7-linux2.deb

[isuro]

And indeed:

$ npx ts-node
> process.platform
'linux'

[isuro]

According to the source map, the case wasn't built in somehow:

[shiftkey]

Cool, that gives me some context to dig into @isuro - thanks for poking at the package contents...

[isuro]

Ping me if you have a new .deb you'd like me to try out!

[Bezierr]

This is not about the ARM installer but about AMD64.deb .
Issue: Geany is not supported as external editor anymore. This worked up to and including 3.2.5.

(System: Mint 21.1 Mate)

[shiftkey]

@Bezierr

Issue: Geany is not supported as external editor anymore. This worked up to and including 3.2.5.

This was removed in #894 because it doesn't support opening a directory, and I was receiving bug reports about it #871

[Bezierr]

@shiftkey
Ok. I never tried opening a directory but only individual files, which works (worked) as it's supposed to. So I guess I'll have to stick with 3.2.5 .

Anyway, thanks a lot for providing this for Linux -- really much appreciated!

[shiftkey]

@isuro just letting you know that the newest release (3.2.8-linux1) has fixed this issue with the github command line helper.

[sabrehagen]

My environment uses OpenGL 2.1. The UI renders without some elements. Screenshot for reference:

Terminal log:

[1200283:1014/012916.918090:ERROR:shared_context_state.cc(77)] Skia shader compilation error
------------------------
#version 100

#extension GL_EXT_blend_func_extended : require
precision mediump float;
precision mediump sampler2D;
uniform sampler2D uTextureSampler_0_S0;
varying highp vec2 vTextureCoords_S0;
varying highp float vTexIndex_S0;
varying mediump vec4 vinColor_S0;
void main() {
    mediump vec4 outputColor_S0;
    outputColor_S0 = vinColor_S0;
    mediump vec4 texColor;
    {
        texColor = texture2D(uTextureSampler_0_S0, vTextureCoords_S0, -0.5);
    }
    mediump vec4 outputCoverage_S0 = texColor;
    {
        outputCoverage_S0.w = max(max(outputCoverage_S0.x, outputCoverage_S0.y), outputCoverage_S0.z);
        gl_SecondaryFragColorEXT = outputColor_S0.w * outputCoverage_S0;
        gl_FragColor = outputColor_S0 * outputCoverage_S0;
    }
}

Errors:
0:1(12): warning: extension `GL_ARB_gpu_shader5' unsupported in fragment shader
0:2(12): warning: extension `GL_EXT_gpu_shader5' unsupported in fragment shader
0:3(1): error: `out' qualifier in declaration of `webgl_SecondaryFragColor' only valid for function parameters in GLSL 1.10
0:0(0): error: fragment shader writes to both `gl_FragColor' and `webgl_SecondaryFragColor'

[Lunarequest]

I've had similar output when my nvidia driver updated. Maybe its the same for you? You could try disabling gpu bug workarounds?

[sabrehagen]

I've had similar output when my nvidia driver updated. Maybe its the same for you? You could try disabling gpu bug workarounds?

Yes, using GITHUB_DESKTOP_DISABLE_HARDWARE_ACCELERATION=1 github-desktop worked. Thank you!

[shiftkey]

Closing this out as things appear to be stable, and I suspect folks are fine to open fresh issues for whatever support questions they have