Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amount KeySend received correct, amount KeySend sent isn't #146

Closed
ghost opened this issue Jul 27, 2020 · 4 comments · Fixed by ElementsProject/lightning#3881
Closed

Amount KeySend received correct, amount KeySend sent isn't #146

ghost opened this issue Jul 27, 2020 · 4 comments · Fixed by ElementsProject/lightning#3881

Comments

@ghost
Copy link

ghost commented Jul 27, 2020

EDIT: it's equally true for the pay command (for c-lightning v0.9.0rc3). Receiving amount is displayed correctly, sent amount isn't.

I just sent 10 satoshi from my test lightning node to my main lightning node (both running c-lightning v0.9.0rc3) and Spark Wallet correctly displayed (for my main node) the received amount. The description was also correct "Spontaneous incoming payment through keysend"

I then sent 10 satoshi from my main lightning node to my test node and the sent amount was not correctly displayed, only "- sat" is visible. The description for the destination is empty.

The total balance is correctly updated.

@ghost ghost changed the title Balance KeySend received correct, balance KeySend sent isn't Amount KeySend received correct, amount KeySend sent isn't Jul 27, 2020
@cdecker
Copy link

cdecker commented Jul 27, 2020

This is an issue on the c-lightning side, where we inadvertently changed the interface for listsendpays. See ElementsProject/lightning#3881 for the fix of this issue. I tested it against my Spark node and it works like a charm.

Sorry for breaking this, mea culpa :-)

@ghost
Copy link
Author

ghost commented Jul 27, 2020

Haha well, glad it gets fixed so fast. I'll close the issue when the fix gets merged and I've tested it as well. After having used sendinvoiceless for some time now, it's great to see an official and integrated implementation like KeySend.

@ghost
Copy link
Author

ghost commented Jul 28, 2020

it works like a charm

Can confirm!

@ghost ghost closed this as completed Jul 28, 2020
@cdecker
Copy link

cdecker commented Jul 28, 2020

Thanks for confirming 👍

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant