clean: don't reinvent fileName(); (xiaoyifang#2138)

shenlebantongying · Feb 9, 2025 · d083fe2 · d083fe2
1 parent 1c2d6c4
commit d083fe2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/dict/slob.cc b/src/dict/slob.cc
@@ -703,9 +703,7 @@ SlobDictionary::SlobDictionary( string const & id, string const & indexFile, vec
 
   dictionaryName = sf.getDictionaryName().toStdString();
   if ( dictionaryName.empty() ) {
-    QString name   = QDir::fromNativeSeparators( dictionaryFiles[ 0 ].c_str() );
-    auto n         = name.lastIndexOf( '/' );
-    dictionaryName = name.mid( n + 1 ).toStdString();
+    dictionaryName = QFileInfo( QString::fromStdString( dictionaryFiles[ 0 ] ) ).fileName().toStdString();
   }
 
   // Full-text search parameters

diff --git a/src/dict/zim.cc b/src/dict/zim.cc
@@ -236,9 +236,7 @@ ZimDictionary::ZimDictionary( string const & id, string const & indexFile, vecto
 
   dictionaryName = df.getMetadata( "Title" );
   if ( dictionaryName.empty() ) {
-    QString name   = QDir::fromNativeSeparators( dictionaryFiles[ 0 ].c_str() );
-    int n          = name.lastIndexOf( '/' );
-    dictionaryName = name.mid( n + 1 ).toStdString();
+    dictionaryName = QFileInfo( QString::fromStdString( dictionaryFiles[ 0 ] ) ).fileName().toStdString();
   }
 
   // Full-text search parameters