Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Innaccurate test helper message #481

Closed
robwise opened this issue Jul 20, 2016 · 1 comment
Closed

Innaccurate test helper message #481

robwise opened this issue Jul 20, 2016 · 1 comment
Labels
bug

Comments

@robwise
Copy link
Contributor

robwise commented Jul 20, 2016

react_on_rails/lib/react_on_rails/test_helper/ensure_assets_compiled.rb

Line 48 in 0118cea

/client level package.json `build:test` command.

This is misleading, we have made it so you can use whatever command you want, so you may not necessarily be doing npm run build:test
@robwise robwise added the bug label Jul 20, 2016
@robwise robwise changed the title Innaccurate message Innaccurate test helper message Jul 20, 2016
@justin808 justin808 mentioned this issue Jul 21, 2016
Merged
@justin808
Copy link
Member

Fixed by #483.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justin808 @robwise