Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use addEventListener directly #109

Closed
joeyparrish opened this issue Jun 18, 2015 · 0 comments
Closed

Do not use addEventListener directly #109

joeyparrish opened this issue Jun 18, 2015 · 0 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly type: code health A code health issue
Milestone
v1.4.0

Comments

@joeyparrish
Copy link
Member

There is one instance in StreamVideoSource where we should be using EventManager, but instead are using addEventListener directly. This could lead to memory leaks or events being handled by objects that have already been destroyed.
@joeyparrish joeyparrish added type: bug Something isn't working correctly type: code health A code health issue labels Jun 18, 2015
@joeyparrish joeyparrish added this to the v1.4.0 milestone Jun 18, 2015
@tdrews tdrews self-assigned this Jun 22, 2015
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly type: code health A code health issue
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
4 participants
@TheModMaker @joeyparrish @tdrews @shaka-bot