-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacejam complains /local route doesn't exist #1
Comments
Hello !
you are using node Easy way to test if things are working on your computer : clone this repo, and try to execute commands from the circle.yml file ( npm install then any mocha test)
I don't remember how I fixed that error, try to update your mocha dependency to get the same dependencies than this example |
Thx for the help! Okay, this is interesting. I cloned this repo and everything ran just fine. However, my repo still isn't working. I made sure my repo fixed to The key difference is when I run the Do you know where that's coming from? btw - I have spacejam in my devDependencies: |
Ah, I see. It's coming from your forked spacejam. I have a very limited understanding of how all these test runners interact with each other so could you explain why the fork was needed? Linking to your fork seemed to get me farther but it still complains about /local:
|
Can you try to remove My spacejam fork :
Try to launch your app with coverage and see if the error is present on your console:
I think your issue will be reproducible, and in that case spacejam is not related to that issue. Lastly, can you try to add all of your dependency to
No it's not. You see log when a file is read and instrumented, which does not occur when coverage is not enabled. But your test crash on the same point, when the phantomjs browser opens your page test. Please update practicalmeteor:mocha-console-runner@0.2.1 to practicalmeteor:mocha-console-runner@0.2.3 |
Okay, a couple updates:
Where is that /local route coming from? |
Did you open the browser console ? I hope that you have the same error on your console, otherwise it will be harder to found out where the problem is. I don't think the /local has any importance, but it comes from there : Can you try to clone this current repo, paste your .meteor/packages and .meteor/versions from your app into this one and see if you still have an issue ? |
Progress! Unfortunately the mere presence of the Now what? lol |
I tried adding your library to https://github.com/meteor/todos and end up with the same |
Ok, if you have an issue with /local url, let's test without it. Use this new branch : |
Basically the same result, except it now complains about /:
It seems like there are a bunch of similar complaints: Full output (I'm using meteor-todos):
|
Another one: kadirahq/flow-router#608 |
I forked meteor-todos with your changes so you can get an easy repro: https://github.com/noahsw/todos |
I made a modification of flow router which raises |
That works! Worth submitting to them as a PR? Thx for all your help! |
Yes that's awesome !! I don't know if this is the best fix, but that pull request already exist..! Can you try to run meteor/todos with tests --full-app to see if it printed errors before and now if it's fixed ? |
Yup! Before using your forked flow-router:
and after:
|
I'm so sorry but I wanted to check if |
I'm not sure I'm following you. Before your flow-router fix, the tests won't pass. See my logs above. But with your flow-router fix, they do pass. |
What i'm saying is test full-app may succeed before the flow router fix. Your log shows the test (unit) fails, but I didnt check when test full-app |
I've added the required packages (although I didn't fix
practicalmeteor:mocha@2.4.5_5
)When I try running
meteor npm run test-coverage-app-unit
, I get the following error:phantomjs: There is no route for the path: /local
Full output:
The text was updated successfully, but these errors were encountered: