Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify meanings of unitSymbol, unitSymbolHtml, and unitSymbolUnicode #959

Closed
dylan-sa opened this issue Sep 1, 2023 · 3 comments
Closed

Clarify meanings of unitSymbol, unitSymbolHtml, and unitSymbolUnicode #959

dylan-sa opened this issue Sep 1, 2023 · 3 comments
Labels
impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation)

Comments

@dylan-sa
Copy link
Contributor

dylan-sa commented Sep 1, 2023 •
edited
Loading

The annotations for unitSymbol, unitSymbolHtml, and unitSymbolUnicode could be improved to better indicate what each should be used for. Each of the definitions contains 'm?' as an example for square meter--this appears to be rendering error. The annotations could be rephrased without reference to it. Examples should also be separated into skos:examples.

unitSymbolUnicode could be improved with an example: The unicode for square meter is U+33A1.

gist:_percent uses the special character "%" as its unitSymbol, but unit symbols aren't supposed to have special characters. We could revise the annotation for unitSymbol or the symbol for gist:_percent.
@dylan-sa dylan-sa added the impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) label Sep 1, 2023
@rjyounes
Copy link
Collaborator

#992 should be discussed first, since it makes this moot.

This was referenced Oct 26, 2023
Closed
Closed
@rjyounes
Copy link
Collaborator

rjyounes commented Nov 8, 2023

@dylan-sa Has this been addressed in PR #997? If so, please close this issue.

@dylan-sa
Copy link
Contributor Author

dylan-sa commented Nov 8, 2023

Yes, #997 cleared things up nicely.

@dylan-sa dylan-sa closed this as completed Nov 8, 2023
@rjyounes rjyounes moved this to Done in gist Version 12.1.0 Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation)
Projects
No open projects
gist Version 12.1.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjyounes @dylan-sa