Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to Contributing.md #734

Closed
rjyounes opened this issue Sep 25, 2022 · 4 comments · Fixed by #807
Closed

Additions to Contributing.md #734

rjyounes opened this issue Sep 25, 2022 · 4 comments · Fixed by #807

Comments

@rjyounes
Copy link
Collaborator

If not already included:

  • When you start working on an issue, move to "In Progress" in the project board. There is no automation of this change in state.
  • When you have submitted the PR for an issue, move the issue to "In Review" in the project board. There is no automation of this change in state.
  • When you have submitted your PR, check that there are no conflicts with develop. If there are, you should resolve them.
@Jamie-SA
Copy link
Contributor

@Jamie-SA will take a first whack for Rebecca to edit.

@Jamie-SA Jamie-SA self-assigned this Jan 26, 2023
@Jamie-SA
Copy link
Contributor

I don't see anything about how we expect release notes are expected to be added to the /docs/ directory and then combined for the release.

@Jamie-SA
Copy link
Contributor

Having to name the release notes with the PR number means you can't have the right filename until after you create the PR. Is there a better way to get around this?

@rjyounes
Copy link
Collaborator Author

I don't see anything about how we expect release notes are expected to be added to the /docs/ directory and then combined for the release.

I have been lax in documenting this. I will try to get that done soon, if not I can tell Steven how to do it.

Having to name the release notes with the PR number means you can't have the right filename until after you create the PR. Is there a better way to get around this?

Yes, that's true. You could use the issue number. The filename is inconsequential, so you can really name it whatever you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment