Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do away with modularity in gist #292

Closed
rjyounes opened this issue May 18, 2020 · 6 comments
Closed

Do away with modularity in gist #292

rjyounes opened this issue May 18, 2020 · 6 comments
Assignees

Comments

@rjyounes
Copy link
Collaborator

rjyounes commented May 18, 2020

Put everything into one file. See #291 for rationale - there may be other issues raising the same point.

I'm starting to come around to the idea that modularity doesn't work in gist - while still supporting it in theory. I believe there are many examples like this one: gist:categorizedBy and gist:Category are not defined in gistCategory, but rather gistTop, because they are referenced either in gistTop or files that import gistTop. Rather than trying to untangle this web of references, perhaps it is best to dump everything into the same file and forget about modularity. gist:hasSubCategory and gist:hasSuperCategory are defined in gistCategory as you would expect.

@rjyounes
Copy link
Collaborator Author

We say this on our website: "Gist is extremely modular. There are several modules that can be used collectively or in subsets if you don't need all the concepts in gist." Needs to be removed if we make this change. In any case it's an overstatement.

@uscholdm
Copy link
Contributor

In any case it's an overstatement.

Another way to put it is to say it was aspirational – IMHO, it was only ever a little true some of the time, and it got less so over time as more stuff migrated to gistTop. Hence the learning.

@rjyounes
Copy link
Collaborator Author

rjyounes commented May 28, 2020

Relates to #260, #288, #198, #67, and #200. Address all issues together.

It might be worth looking for all the issues that relate to modularity and track them from here.

@rjyounes
Copy link
Collaborator Author

rjyounes commented Jun 4, 2020

Agreed at gist Council to move forward on this.

Adding to June 2020 project; let's discuss whether we can get this done for the June release.

@marksem marksem self-assigned this Jun 4, 2020
@marksem
Copy link
Collaborator

marksem commented Jun 11, 2020

AC)

  1. No more catalog-v001.xml will be needed.
  2. Just gistDeprecated.owl and gistCore.owl needed (top level)
  3. Update bundling/packaging to still inject proper version number and create good folder shape.
  4. Remove other "topic:modularity" tickets except Use a tool that allows users to create modules for specific purposes #201
  5. No more imports diagram generation

@rjyounes
Copy link
Collaborator Author

rjyounes commented Jun 11, 2020

Meika will finish #93, the PR will be merged, then all other modifications will be postponed till Mark's work is finished. Whoever merges the PR, please send out notification to the group to stop work.

Mark will then implement this and notify others to continue working on other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants