diff --git a/__tests__/elect-build-leader.js b/__tests__/elect-build-leader.js index 59fa634..416dc7c 100644 --- a/__tests__/elect-build-leader.js +++ b/__tests__/elect-build-leader.js @@ -5,6 +5,8 @@ const electBuildLeader = require('../elect-build-leader') test('find highest node version in build matrix', t => { t.is(electBuildLeader('1'), 1, 'no matrix') + t.is(electBuildLeader([3, '2', 1]), 1, 'version as integers') + t.is(electBuildLeader([ '8', '4', diff --git a/elect-build-leader.js b/elect-build-leader.js index fd495b5..ed9e41f 100644 --- a/elect-build-leader.js +++ b/elect-build-leader.js @@ -9,6 +9,8 @@ module.exports = versions => { const stable = versions.indexOf('node') + 1 if (stable) return stable + // Convert to Strings as expected by semver + versions = versions.map(version => String(version)) // otherwise we use the lower bound of all valid semver ranges const validRanges = versions.filter(semver.validRange) const lowVersionBoundaries = validRanges