From 66c59d9b98491ddd250af99afc873f4c71bc832e Mon Sep 17 00:00:00 2001 From: David Bordoley Date: Fri, 8 Mar 2024 13:14:13 -0500 Subject: [PATCH] a few simplifications --- .../destinations/snap-conversions-api/_tests_/capiV3tests.ts | 2 +- .../snap-conversions-api/reportConversionEvent/snap-capi-v3.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/destination-actions/src/destinations/snap-conversions-api/_tests_/capiV3tests.ts b/packages/destination-actions/src/destinations/snap-conversions-api/_tests_/capiV3tests.ts index 4639b37d30..f77011f404 100644 --- a/packages/destination-actions/src/destinations/snap-conversions-api/_tests_/capiV3tests.ts +++ b/packages/destination-actions/src/destinations/snap-conversions-api/_tests_/capiV3tests.ts @@ -676,7 +676,7 @@ export const capiV3tests = () => }, useDefaultMappings: true, auth: { - accessToken, + accessToken: ' access123 ', refreshToken }, features, diff --git a/packages/destination-actions/src/destinations/snap-conversions-api/reportConversionEvent/snap-capi-v3.ts b/packages/destination-actions/src/destinations/snap-conversions-api/reportConversionEvent/snap-capi-v3.ts index c572406d62..20c4159c91 100644 --- a/packages/destination-actions/src/destinations/snap-conversions-api/reportConversionEvent/snap-capi-v3.ts +++ b/packages/destination-actions/src/destinations/snap-conversions-api/reportConversionEvent/snap-capi-v3.ts @@ -171,7 +171,7 @@ export const validateAppOrPixelID = (settings: Settings, event_conversion_type: // Some configurations specify both a snapPixelID and a snapAppID. In these cases // check the conversion type to ensure that the right id is selected and used. - const appOrPixelID = event_conversion_type === 'WEB' ? snapPixelID ?? snapAppID : snapAppID ?? snapPixelID + const appOrPixelID = event_conversion_type === 'WEB' ? snapPixelID : snapAppID raiseMisconfiguredRequiredFieldErrorIf( event_conversion_type === 'MOBILE_APP' && isNullOrUndefined(snapAppID),