Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we shouldn't be saving any new models if running in evaluation mode. #1321

Open
ishaileshpant opened this issue Jan 30, 2025 · 0 comments
Open
Assignees
Milestone

Comments

@ishaileshpant
Copy link
Collaborator

Current behavior:
In evaluation run of the federation the aggregator saves the model protobuf states (best and last pbuf files) which is not relevant for evaluation run as no training is performed.

Affected Version:
1.7

Expected behavior:

We shouldn't save any model proto buf files only an init.pbuf should be sufficient to run a evaluation run and make evaluation run idempotent from model state perspective

@ishaileshpant ishaileshpant added this to the 1.8 milestone Jan 30, 2025
@ishaileshpant ishaileshpant self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant