Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve automated tests to use docker images. #85

Closed
ibrahiminfinite opened this issue Mar 19, 2023 · 3 comments · Fixed by #160
Closed

Improve automated tests to use docker images. #85

ibrahiminfinite opened this issue Mar 19, 2023 · 3 comments · Fixed by #160
Assignees
Labels
enhancement New feature or request tools Software tools and infrastructure

Comments

@ibrahiminfinite
Copy link
Collaborator

ibrahiminfinite commented Mar 19, 2023

The current automated tests take a lot of time to run.
This could be improved by using docker images which are built weekly (as suggested by @sea-bass ) and also adding a manually triggered workflow to rebuild a docker image in case of a requirement to rebuild between the automated build interval.

EDIT :
It might also be useful to make the tests run based on dependencies.
For example,
The python tests only run if format tests pass
The ROS tests only run once the python tests pass.

@ibrahiminfinite ibrahiminfinite added enhancement New feature or request tools Software tools and infrastructure labels Mar 19, 2023
@sea-bass
Copy link
Owner

Another option would be to use the GitHub Actions cache, which is for sure going to help with the Docker tests... but not with the standalone Python ones, necessarily. Although it should be possible to use a ROS free Docker container for that too.

@ibrahiminfinite
Copy link
Collaborator Author

Although it should be possible to use a ROS free Docker container for that too.

This will be good. The tests take too long to run right now and most of the time is spent in setting up stuff, especially the PDDLStream

@sea-bass
Copy link
Owner

sea-bass commented Feb 7, 2024

Seems @eholum is looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tools Software tools and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants